FreePBX
  1. FreePBX
  2. FREEPBX-5687

call waiting indication to caller in cases that the dialed extension is in use or busy

    Details

    • Type: Improvement Improvement
    • Status: Open (View Workflow)
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.10, 2.11
    • Fix Version/s: None
    • Component/s: Follow Me
    • Labels:
    • Target Release:
    • Backend Engine:
      Asterisk 1.8
    • Confirmation:
      Unreviewed
    • ToDo:

      Description

      Hello,

      I would like to offer a feature request that will indicate a call waiting tone to the caller in cases when the dialed extension is in use or busy.

      instead of this line in macro-dial-one:

      exten => s,n(godial),Dial(${DSTRING},${ARG1},${D_OPTIONS})
      

      you can replace this line with this code sample:

      exten => s,n(godial),GotoIf($["${EXTENSION_STATE(${DEXTEN})}"="UNAVAILABLE" | "${EXTENSION_STATE(${DEXTEN})}"="NOT_INUSE" | "${EXTENSION_STATE(${DEXTEN})}"="UNKNOWN"]?dial:dialbusy)
      exten => s,n(dialbusy),GotoIf($["${EXTENSION_STATE(${DEXTEN})}" = "BUSY"]?dialcallwaiting)
      exten => s,n(dialcallwaiting),Dial(${DSTRING},${ARG1},r(callwaiting))
      exten => s,n(dial),Dial(${DSTRING},${ARG1},${D_OPTIONS})
      

      There is still a problem with the dialparties.agi. When ever an extension has a followme (that uses the dialparties.agi), this change will not take effect.

      Moshe, can you please take a look at that and add a fix to all the dial macros (including the dialparties.agi)? all you need to add when the extension state's in-use or busy is to add the call waiting indication (it will take is from indications.conf).

      this is the syntax to add a tone to the r option in the Dial application:

      Dial(${DSTRING},${ARG1},r(callwaiting))
      

      Maybe you can add an option in the general settings page to let the users choose if they want to play a call waiting tone when the extension is in-use or busy.

      Thank you,

      Daniel Friedman
      Trixton

      Tel: 972.72.2557000
      Mobile: 972.50.6655579

      Email: dani@3xton.com

        Activity

        Hide
        danielf added a comment -

        any news on that feature?

        Show
        danielf added a comment - any news on that feature?
        Hide
        danielf added a comment -

        still no comments?

        Show
        danielf added a comment - still no comments?
        Hide
        Andrew Nagy added a comment -

        There is a certain flow of ticket progression. We will get to this. Please don't change priorities to make your tickets higher.

        Show
        Andrew Nagy added a comment - There is a certain flow of ticket progression. We will get to this. Please don't change priorities to make your tickets higher.
        Hide
        jfinstrom added a comment -

        We are happy to look at this and we understand the gist of the request. We have some logistic concerns.

        1. Is this global or user based.
        2. Does this need to be a checkbox enabled/disabled by user or globally.

        We worry about privacy concerns of running this across the board and blanket implementation.

        If there is enough interest (votes) for this we will revisit it.

        Show
        jfinstrom added a comment - We are happy to look at this and we understand the gist of the request. We have some logistic concerns. 1. Is this global or user based. 2. Does this need to be a checkbox enabled/disabled by user or globally. We worry about privacy concerns of running this across the board and blanket implementation. If there is enough interest (votes) for this we will revisit it.
        Hide
        danielf added a comment -

        hi James,

        thank you for taking care of this feature. it is a highly important feature as it suppose to help the users who do not use "smart" ip phones, i.e.: ip phones with a screen or an analog phone that is connected to a FXS device.

        it is suppose to be a global behavior feature and an independent one. similar to the dial options in the trunk options.
        i do not think there is a privacy issue because all this feature does is to ring back a call waiting sound instead of a regular one.

        in cases of a call that arrives to a multi line sip ip phone (a phone with six sip accounts for example), this feature would be have to be examined again, because the phone accepts the sip invite with no problems. the disabling of call waiting feature in the extension settings would solve this problem (but will not allow the ip phone to accept another call).

        anyhow, i am asking to add this feature for many years (since the earliest Freepbx versions), but with no luck. it drives me to fork to my own version and maintain it by myself.
        it is really an important issue and it is been asked by a lot of people, who finally gave up from the Freepbx development team.

        thank you very much for your assistance in this feature.

        Daniel Friedman
        Trixton LTD.

        Tel: 972.72.2557000
        Mobile: 972.50.6655579

        Show
        danielf added a comment - hi James, thank you for taking care of this feature. it is a highly important feature as it suppose to help the users who do not use "smart" ip phones, i.e.: ip phones with a screen or an analog phone that is connected to a FXS device. it is suppose to be a global behavior feature and an independent one. similar to the dial options in the trunk options. i do not think there is a privacy issue because all this feature does is to ring back a call waiting sound instead of a regular one. in cases of a call that arrives to a multi line sip ip phone (a phone with six sip accounts for example), this feature would be have to be examined again, because the phone accepts the sip invite with no problems. the disabling of call waiting feature in the extension settings would solve this problem (but will not allow the ip phone to accept another call). anyhow, i am asking to add this feature for many years (since the earliest Freepbx versions), but with no luck. it drives me to fork to my own version and maintain it by myself. it is really an important issue and it is been asked by a lot of people, who finally gave up from the Freepbx development team. thank you very much for your assistance in this feature. Daniel Friedman Trixton LTD. Tel: 972.72.2557000 Mobile: 972.50.6655579
        Hide
        jviegas added a comment -

        Hello,

        This is a great feature.

        I agree that should be global and I don't see any privacy issue.

        Best regards,

        João Viegas

        Show
        jviegas added a comment - Hello, This is a great feature. I agree that should be global and I don't see any privacy issue. Best regards, João Viegas
        Hide
        Tony Lewis added a comment -

        It can not be global. It has to be a per user settings. Something like this should not be forced onto all users no different then turning on or off call waiting is a per user settings.

        If you have this all done already in your own fork can you make this be a per user settings and also provide a proper patch against 2.11 and we can look at getting it into FreePBX 12. We will also need a code submission agreement back. http://literature.schmoozecom.com/EUA/CodeSubmissionsAgreement-r3.pdf

        Show
        Tony Lewis added a comment - It can not be global. It has to be a per user settings. Something like this should not be forced onto all users no different then turning on or off call waiting is a per user settings. If you have this all done already in your own fork can you make this be a per user settings and also provide a proper patch against 2.11 and we can look at getting it into FreePBX 12. We will also need a code submission agreement back. http://literature.schmoozecom.com/EUA/CodeSubmissionsAgreement-r3.pdf

          People

          • Assignee:
            Unassigned
            Reporter:
            danielf
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development