Details

    • Type: Bugs Bugs
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: None
    • Component/s: Core
    • Labels:
      None
    • Backend Engine:
      All
    • Confirmation:
      Unreviewed

      Description

      Most pages in core open and close a div with the content class. This can mess up the formatting of the page vis a vis the css applied to that class. Additionally, there seems to be no reason or benefit for this bizarre behavior. Here is a patch that should fix it
      - haven't tested on fpbx yet though.

      Index: amp_conf/htdocs/admin/modules/core/page.trunks.php
      ===================================================================
      --- amp_conf/htdocs/admin/modules/core/page.trunks.php	(revision 11367)
      +++ amp_conf/htdocs/admin/modules/core/page.trunks.php	(working copy)
      @@ -303,7 +303,6 @@
       }
       	
       ?>
      -</div>
       
       <div class="rnav">
       <ul>
      @@ -350,7 +349,6 @@
       </ul>
       </div>
       
      -<div class="content">
       
       <?php 
       if (!$tech && !$extdisplay) {
      Index: amp_conf/htdocs/admin/modules/core/page.routing.php
      ===================================================================
      --- amp_conf/htdocs/admin/modules/core/page.routing.php	(revision 11367)
      +++ amp_conf/htdocs/admin/modules/core/page.routing.php	(working copy)
      @@ -313,7 +313,7 @@
       }
       
       ?>
      -</div>
      +
       <script type="text/javascript">
       $(document).ready(function(){
         $("#routelist").sortable({ 
      @@ -368,7 +368,6 @@
       </ul>
       </div>
       
      -<div class="content">
       
       <?php 
       $last_seq = count($routepriority)-1;
      Index: amp_conf/htdocs/admin/modules/core/page.zapchandids.php
      ===================================================================
      --- amp_conf/htdocs/admin/modules/core/page.zapchandids.php	(revision 11367)
      +++ amp_conf/htdocs/admin/modules/core/page.zapchandids.php	(working copy)
      @@ -49,7 +49,6 @@
       
       
       ?> 
      -</div>
       
       <div class="rnav"><ul>
       <?php 
      @@ -63,8 +62,6 @@
       ?>
       </ul></div>
       
      -<div class="content">
      -
       <?php
       
       if ($extdisplay != '') {
      Index: amp_conf/htdocs/admin/modules/core/page.ampusers.php
      ===================================================================
      --- amp_conf/htdocs/admin/modules/core/page.ampusers.php	(revision 11367)
      +++ amp_conf/htdocs/admin/modules/core/page.ampusers.php	(working copy)
      @@ -109,8 +109,8 @@
       }
       
       ?>
      -</div>
       
      +
       <div class="rnav">
       <ul>
       	<li><a <?php  echo ($userdisplay=='' ? 'class="current"':'') ?> href="config.php?display=<?php echo urlencode($display)?>"><?php echo _("Add User")?></a></li>
      @@ -125,8 +125,6 @@
       </ul>
       </div>
       
      -<div class="content">
      -
       <?php 
       
       	if ($userdisplay) {
      Index: amp_conf/htdocs/admin/modules/core/page.did.php
      ===================================================================
      --- amp_conf/htdocs/admin/modules/core/page.did.php	(revision 11367)
      +++ amp_conf/htdocs/admin/modules/core/page.did.php	(working copy)
      @@ -73,7 +73,6 @@
       }
       
       ?>
      -</div>
       
       <?php
       $display_link = "config.php?display=$dispnum";
      @@ -133,7 +132,6 @@
       </ul>
       </div>
       
      -<div class="content">
       <?php 
       	if ($action == 'delIncoming') {
       		echo '<br><h3>Route '.$extdisplay.' '._("deleted").'!</h3><br><br><br><br><br><br><br><br>';
      
      

        Activity

        Hide
        Moshe Brevda added a comment -

        (In http://www.freepbx.org/trac/changeset/12208) closes FREEPBX-5128
        - dont open and close cosmetic class for no reason

        Show
        Moshe Brevda added a comment - (In http://www.freepbx.org/trac/changeset/12208 ) closes FREEPBX-5128 - dont open and close cosmetic class for no reason

          People

          • Assignee:
            Philippe Lindheimer
            Reporter:
            Moshe Brevda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development