Details

    • Backend Engine:
      Asterisk 1.8
    • Confirmation:
      Unreviewed

      Description

      SIP Extension should support transport both TCP and UDP

      Currently, it is allowed to choose only UDP or TCP/TLS. If choosing UDP, then TCP is not allowed. If choosing TCP, then UDP is not allowed. I think it should support both TCP and UDP

        Activity

        Hide
        Philippe Lindheimer added a comment -

        please read the tooltip and corresponding Asterisk documentation if the tooltip is not adequate.

        Show
        Philippe Lindheimer added a comment - please read the tooltip and corresponding Asterisk documentation if the tooltip is not adequate.
        Hide
        tpenguin added a comment -

        Replying to [p_lindheimer|comment:1]:
        > please read the tooltip and corresponding Asterisk documentation if the tooltip is not adequate.

        According to Asterisk documentation,

        http://www.asterisk.org/doxygen/trunk/Config_sip.html

        default transport is "transport=udp,tcp", It uses UDP as outgoing, and accept BOTH UDP and TCP.

        But now, Freepbx only allows to set "UDP" / "TCP or TLS".
        So, if I choose "UDP", then in sip_additional.conf, "transport=udp", therefore, Freepbx will only accept UDP.
        If I choose "TCP", then in sip_additional.conf, "transport=tcp", therefore, Freepbx will only accept TCP.

        There are no "transport=udp,tcp".

        I think Freepbx should allow the following transport options

        1. transport=udp only
        2. transport=tcp only
        3. transport=udp,tcp (it should be a default option)

        Show
        tpenguin added a comment - Replying to [p_lindheimer|comment:1] : > please read the tooltip and corresponding Asterisk documentation if the tooltip is not adequate. According to Asterisk documentation, http://www.asterisk.org/doxygen/trunk/Config_sip.html default transport is "transport=udp,tcp", It uses UDP as outgoing, and accept BOTH UDP and TCP. But now, Freepbx only allows to set "UDP" / "TCP or TLS". So, if I choose "UDP", then in sip_additional.conf, "transport=udp", therefore, Freepbx will only accept UDP. If I choose "TCP", then in sip_additional.conf, "transport=tcp", therefore, Freepbx will only accept TCP. There are no "transport=udp,tcp". I think Freepbx should allow the following transport options 1. transport=udp only 2. transport=tcp only 3. transport=udp,tcp (it should be a default option)
        Hide
        Moshe Brevda added a comment -

        @tpenguin
        -
        Default transport is still udp. transport=udp,tcp means that asterisk support ANY of those options (ot all by default).

        @p_lindheimer
        - "This sets the default transport type to udp for outgoing" means that if NOTHING is set, they default is for udp. Looking only at the gui though, it would apear as if the user must chose between udp OR tcp (as we specify the option). I think we should have a third option (and default to it, unless there are VALID security concerns) for TCP & UDP

        Show
        Moshe Brevda added a comment - @tpenguin - Default transport is still udp. transport=udp,tcp means that asterisk support ANY of those options (ot all by default). @p_lindheimer - "This sets the default transport type to udp for outgoing" means that if NOTHING is set, they default is for udp. Looking only at the gui though, it would apear as if the user must chose between udp OR tcp (as we specify the option). I think we should have a third option (and default to it, unless there are VALID security concerns) for TCP & UDP
        Hide
        Philippe Lindheimer added a comment -

        reopening based on the clarification, you are right I mis-read the documentation.

        Now before making this fix so we get it right for good, does anyone want to comment on FREEPBX-4801 wrt to tls?

        Show
        Philippe Lindheimer added a comment - reopening based on the clarification, you are right I mis-read the documentation. Now before making this fix so we get it right for good, does anyone want to comment on FREEPBX-4801 wrt to tls?
        Hide
        Philippe Lindheimer added a comment -

        (In http://www.freepbx.org/trac/changeset/11712) fixes FREEPBX-4801 and closes FREEPBX-4905 changed to allow only specific transports or all transports specifying each as primary, 6 settings total, I don't think we want to add another 6 settings for each pair in both orders.

        Show
        Philippe Lindheimer added a comment - (In http://www.freepbx.org/trac/changeset/11712 ) fixes FREEPBX-4801 and closes FREEPBX-4905 changed to allow only specific transports or all transports specifying each as primary, 6 settings total, I don't think we want to add another 6 settings for each pair in both orders.

          People

          • Assignee:
            Philippe Lindheimer
            Reporter:
            tpenguin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development