Details

    • Type: Bugs
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: None
    • Component/s: Flash Operator Panel
    • Labels:
      None

      Description

      these changes are necessary for the flash operator panel to correctly show DND/CF status
      if the DND/CF was set using FreePBX's *-codes.

        Attachments

          Activity

          Hide
          francesco_r francesco_r added a comment -

          For Nick Lewis: in (III) you say that FOP reads DND or CF status only at startup. This is not true. As you can see in FREEPBX-2110 you must simply add an event extension in asterisk, like:

          exten => *78,n,UserEvent(ASTDB|Channel: ${CHANNEL}^Family: dnd^Value: Enabled)

          So for *78 the php code to put before the playback row is:

          $ext->add($id, $c, '', new ext_userevent('ASTDB|Family: DND^Value: Enabled'));

          and for *79:

          $ext->add($id, $c, '', new ext_userevent('ASTDB|Family: DND^Value: ^'));
           

          Show
          francesco_r francesco_r added a comment - For Nick Lewis: in (III) you say that FOP reads DND or CF status only at startup. This is not true. As you can see in FREEPBX-2110 you must simply add an event extension in asterisk, like: exten => *78,n,UserEvent(ASTDB|Channel: ${CHANNEL}^Family: dnd^Value: Enabled) So for *78 the php code to put before the playback row is: $ext->add($id, $c, '', new ext_userevent('ASTDB|Family: DND^Value: Enabled')); and for *79: $ext->add($id, $c, '', new ext_userevent('ASTDB|Family: DND^Value: ^'));  
          Hide
          Nick_Lewis Nick_Lewis added a comment -

          Yes I see now that it would be possible to send an event to FOP that emulates the output from request_astdb_status()

          However I think there may be a problem with these events. When disabling the DND or CF (or other family), the event does not take into account the current state of the other families. So for example if a channel has two families enabled and one is later disabled, FOP will show none enabled. It is only by reference to the database that another still active family can be displayed. Therefore I think a method based on polling request_astdb_status() has an advantage.

          Show
          Nick_Lewis Nick_Lewis added a comment - Yes I see now that it would be possible to send an event to FOP that emulates the output from request_astdb_status() However I think there may be a problem with these events. When disabling the DND or CF (or other family), the event does not take into account the current state of the other families. So for example if a channel has two families enabled and one is later disabled, FOP will show none enabled. It is only by reference to the database that another still active family can be displayed. Therefore I think a method based on polling request_astdb_status() has an advantage.
          Hide
          francesco_r francesco_r added a comment -

          Yes, you are right Nick. Was for this reason i did the patch only for DND and not for CF.

          Show
          francesco_r francesco_r added a comment - Yes, you are right Nick. Was for this reason i did the patch only for DND and not for CF.
          Hide
          drmessano Danny Messano added a comment -

          Fixed in (http://www.freepbx.org/trac/changeset/8351)

          I've added a proper diff to FREEPBX-3868, and we should be fine implementing the change there.

          FREEPBX-3874 is most certainly a change in FOP itself, and I refer this to Asternic for review and acceptance. Once this is hashed out and implemented in FOP, we can implement here.

          Show
          drmessano Danny Messano added a comment - Fixed in ( http://www.freepbx.org/trac/changeset/8351 ) I've added a proper diff to FREEPBX-3868 , and we should be fine implementing the change there. FREEPBX-3874 is most certainly a change in FOP itself, and I refer this to Asternic for review and acceptance. Once this is hashed out and implemented in FOP, we can implement here.
          Hide
          p_lindheimer Philippe Lindheimer added a comment -

          r8372

          Show
          p_lindheimer Philippe Lindheimer added a comment - r8372

            People

            • Assignee:
              drmessano Danny Messano
              Reporter:
              alauppe alauppe
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: