Details

    • Type: Feature Requests
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Core
    • Labels:
      None
    • Asterisk Version:
      2.5.0.0

      Description

      hi,

      currently freepbx supports the func_devstate on 1.4 (backported from 1.6) using the DEVSTATE function in the dialplan

      however, when using asterisk 1.6, the function should be DEVICE_STATE.

      Cheers

        Attachments

          Activity

          Hide
          p_lindheimer Philippe Lindheimer added a comment -

          I have changes for FreePBX (but not ARI) pending for this, however I discussed it with Russellb at Astricon this week and will be checking back with him to see if 1.6 might consider supporting both formats. The issue is that func_devstate.c was never part of 1.4 because if it was, they would either not change it or support both by policy. However, there are many users who have taken advantage of it in the Asterisk world so even if we fix it in FreePBX (like we will if needed), it still breaks those users who adopted the unofficial patch when the migrate to 1.6.

          Show
          p_lindheimer Philippe Lindheimer added a comment - I have changes for FreePBX (but not ARI) pending for this, however I discussed it with Russellb at Astricon this week and will be checking back with him to see if 1.6 might consider supporting both formats. The issue is that func_devstate.c was never part of 1.4 because if it was, they would either not change it or support both by policy. However, there are many users who have taken advantage of it in the Asterisk world so even if we fix it in FreePBX (like we will if needed), it still breaks those users who adopted the unofficial patch when the migrate to 1.6.
          Hide
          p_lindheimer Philippe Lindheimer added a comment -

          (In http://www.freepbx.org/trac/changeset/6913) re FREEPBX-3213 used DEVICE_STATE for Asterisk 1.6+, fixes all but ARI

          Show
          p_lindheimer Philippe Lindheimer added a comment - (In http://www.freepbx.org/trac/changeset/6913 ) re FREEPBX-3213 used DEVICE_STATE for Asterisk 1.6+, fixes all but ARI
          Hide
          p_lindheimer Philippe Lindheimer added a comment -

          (In http://www.freepbx.org/trac/changeset/7048) closes FREEPBX-3213 DEVICE_STATE with Asterisk 1.6 (will be merging back to 2.5 branch)

          Show
          p_lindheimer Philippe Lindheimer added a comment - (In http://www.freepbx.org/trac/changeset/7048 ) closes FREEPBX-3213 DEVICE_STATE with Asterisk 1.6 (will be merging back to 2.5 branch)
          Hide
          p_lindheimer Philippe Lindheimer added a comment -

          (In http://www.freepbx.org/trac/changeset/7103) Merged revisions 6980-7048 via svnmerge from
          http://svn.freepbx.org/freepbx/trunk

          Merge back ARI inline playback and callme functions and call screening
          option in phonefeatures to 2.5 to create an ari release candidate

          ................

          (http://www.freepbx.org/trac/changeset/6980) | p_lindheimer | 2008-10-13 20:38:08 -0700 (Mon, 13 Oct 2008) | 69 lines

          Merged revisions 6420-6456,6458,6460-6976,6978-6979 via svnmerge from

          http://svn.freepbx.org/freepbx/branches/ari_changes

          Removes ARI popup and puts player inline for voicemail and callmonitor

          also adds callback ability to phone, requires change to core not yet

          checked in.

          ........

          (http://www.freepbx.org/trac/changeset/6980) | p_lindheimer | 2008-08-18 08:21:56 -0700 (Mon, 18 Aug 2008) | 1 line

          create ari_changes branch to try some new stuff and would be good to move all AMI to phpagi-asmanager.php library

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-18 11:21:59 -0700 (Mon, 18 Aug 2008) | 1 line

          ARI: adds inline playback, call me and download

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-22 06:58:34 -0700 (Fri, 22 Aug 2008) | 1 line

          ARI: update callmonitor.module for inline play and download

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-22 12:17:36 -0700 (Fri, 22 Aug 2008) | 1 line

          ARI: voicemail.module changed 'private' to 'var' for php4 compatibility

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-25 08:18:41 -0700 (Mon, 25 Aug 2008) | 1 line

          ARI: Fixed additional encryption calls to properly urlencode

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-25 14:06:20 -0700 (Mon, 25 Aug 2008) | 1 line

          ARI: fix crypt calls to not urlencode form field values

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-30 06:23:13 -0700 (Sat, 30 Aug 2008) | 1 line

          ARI: cleanup unused variables and remove popup.css

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-08-30 06:25:19 -0700 (Sat, 30 Aug 2008) | 1 line

          ARI: remove popup.css (for real this time)

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-08 05:41:20 -0700 (Mon, 08 Sep 2008) | 1 line

          ARI: remove unused variables for call me feature

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-08 05:47:32 -0700 (Mon, 08 Sep 2008) | 1 line

          ARI: update version for ari_changes branch

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-10 06:06:01 -0700 (Wed, 10 Sep 2008) | 1 line

          ARI: add value='yes' to checkbox tags

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-22 07:09:56 -0700 (Mon, 22 Sep 2008) | 1 line

          manual merge of ARI fixes up to (http://www.freepbx.org/trac/changeset/6980) from 2.5 branch to ari_changes branch

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-22 10:10:27 -0700 (Mon, 22 Sep 2008) | 1 line

          ARI: update callme feature to use phpagi-asmanager for Asterisk Manager Interface

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-09-24 09:47:16 -0700 (Wed, 24 Sep 2008) | 1 line

          ARI: fix play_page.php to pass recindex instead of path of file to play

          ........

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-10-13 20:17:56 -0700 (Mon, 13 Oct 2008) | 1 line

          small fix for ARI changes after merge from trunk

          ........

          ................

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-10-14 14:19:58 -0700 (Tue, 14 Oct 2008) | 1 line

          add vm-callme context to dialplan, update callme.php to drop calls into vm-callme context

          ................

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-10-16 08:26:52 -0700 (Thu, 16 Oct 2008) | 1 line

          ARI: add call screening control to Phone Features page

          ................

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-10-20 06:49:54 -0700 (Mon, 20 Oct 2008) | 1 line

          ARI: make and globally available for modules

          ................

          (http://www.freepbx.org/trac/changeset/6980) | sasargen | 2008-10-20 08:12:44 -0700 (Mon, 20 Oct 2008) | 1 line

          ARI: allow hangup of callme calls to extensions with special characters

          ................

          (http://www.freepbx.org/trac/changeset/6980) | p_lindheimer | 2008-10-20 09:07:43 -0700 (Mon, 20 Oct 2008) | 1 line

          add php-asmanager.php to included files for switch over to phpagi libraries

          ................

          (http://www.freepbx.org/trac/changeset/6980) | p_lindheimer | 2008-10-20 09:39:03 -0700 (Mon, 20 Oct 2008) | 1 line

          move to proper astman global for manager connection

          ................

          (http://www.freepbx.org/trac/changeset/6980) | p_lindheimer | 2008-10-20 10:36:13 -0700 (Mon, 20 Oct 2008) | 1 line

          closes FREEPBX-3213 DEVICE_STATE with Asterisk 1.6 (will be merging back to 2.5 branch)

          ................

          Show
          p_lindheimer Philippe Lindheimer added a comment - (In http://www.freepbx.org/trac/changeset/7103 ) Merged revisions 6980-7048 via svnmerge from http://svn.freepbx.org/freepbx/trunk Merge back ARI inline playback and callme functions and call screening option in phonefeatures to 2.5 to create an ari release candidate ................ ( http://www.freepbx.org/trac/changeset/6980 ) | p_lindheimer | 2008-10-13 20:38:08 -0700 (Mon, 13 Oct 2008) | 69 lines Merged revisions 6420-6456,6458,6460-6976,6978-6979 via svnmerge from http://svn.freepbx.org/freepbx/branches/ari_changes Removes ARI popup and puts player inline for voicemail and callmonitor also adds callback ability to phone, requires change to core not yet checked in. ........ ( http://www.freepbx.org/trac/changeset/6980 ) | p_lindheimer | 2008-08-18 08:21:56 -0700 (Mon, 18 Aug 2008) | 1 line create ari_changes branch to try some new stuff and would be good to move all AMI to phpagi-asmanager.php library ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-18 11:21:59 -0700 (Mon, 18 Aug 2008) | 1 line ARI: adds inline playback, call me and download ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-22 06:58:34 -0700 (Fri, 22 Aug 2008) | 1 line ARI: update callmonitor.module for inline play and download ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-22 12:17:36 -0700 (Fri, 22 Aug 2008) | 1 line ARI: voicemail.module changed 'private' to 'var' for php4 compatibility ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-25 08:18:41 -0700 (Mon, 25 Aug 2008) | 1 line ARI: Fixed additional encryption calls to properly urlencode ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-25 14:06:20 -0700 (Mon, 25 Aug 2008) | 1 line ARI: fix crypt calls to not urlencode form field values ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-30 06:23:13 -0700 (Sat, 30 Aug 2008) | 1 line ARI: cleanup unused variables and remove popup.css ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-08-30 06:25:19 -0700 (Sat, 30 Aug 2008) | 1 line ARI: remove popup.css (for real this time) ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-08 05:41:20 -0700 (Mon, 08 Sep 2008) | 1 line ARI: remove unused variables for call me feature ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-08 05:47:32 -0700 (Mon, 08 Sep 2008) | 1 line ARI: update version for ari_changes branch ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-10 06:06:01 -0700 (Wed, 10 Sep 2008) | 1 line ARI: add value='yes' to checkbox tags ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-22 07:09:56 -0700 (Mon, 22 Sep 2008) | 1 line manual merge of ARI fixes up to ( http://www.freepbx.org/trac/changeset/6980 ) from 2.5 branch to ari_changes branch ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-22 10:10:27 -0700 (Mon, 22 Sep 2008) | 1 line ARI: update callme feature to use phpagi-asmanager for Asterisk Manager Interface ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-09-24 09:47:16 -0700 (Wed, 24 Sep 2008) | 1 line ARI: fix play_page.php to pass recindex instead of path of file to play ........ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-10-13 20:17:56 -0700 (Mon, 13 Oct 2008) | 1 line small fix for ARI changes after merge from trunk ........ ................ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-10-14 14:19:58 -0700 (Tue, 14 Oct 2008) | 1 line add vm-callme context to dialplan, update callme.php to drop calls into vm-callme context ................ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-10-16 08:26:52 -0700 (Thu, 16 Oct 2008) | 1 line ARI: add call screening control to Phone Features page ................ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-10-20 06:49:54 -0700 (Mon, 20 Oct 2008) | 1 line ARI: make and globally available for modules ................ ( http://www.freepbx.org/trac/changeset/6980 ) | sasargen | 2008-10-20 08:12:44 -0700 (Mon, 20 Oct 2008) | 1 line ARI: allow hangup of callme calls to extensions with special characters ................ ( http://www.freepbx.org/trac/changeset/6980 ) | p_lindheimer | 2008-10-20 09:07:43 -0700 (Mon, 20 Oct 2008) | 1 line add php-asmanager.php to included files for switch over to phpagi libraries ................ ( http://www.freepbx.org/trac/changeset/6980 ) | p_lindheimer | 2008-10-20 09:39:03 -0700 (Mon, 20 Oct 2008) | 1 line move to proper astman global for manager connection ................ ( http://www.freepbx.org/trac/changeset/6980 ) | p_lindheimer | 2008-10-20 10:36:13 -0700 (Mon, 20 Oct 2008) | 1 line closes FREEPBX-3213 DEVICE_STATE with Asterisk 1.6 (will be merging back to 2.5 branch) ................

            People

            • Assignee:
              p_lindheimer Philippe Lindheimer
              Reporter:
              kopspa kopspa
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: